Chun-Sheng, Li comments

Results 429 comments of


                                            Chun-Sheng, Li

fix: Resolve readline patch attempting to apply to php >7.1 due to OR instead of AND

Sorry for the delay. I've merged this PR now.

ci: Complete the unit test matrix

Some tests are failed in the `PHP 7.2` and `Phar build test`. Could you help me to fix them? In the `PHP 7.2` test, the error message is as follows:...

Allow .phpbrewrc to handle minor versions

@theofidry, do you mean the feature in the following GIF? ![](https://i.stack.imgur.com/ZfBV7.gif)

"patch for fix readline detection" is broken

- "Running PHP" is about which PHP version you run the PHPBrew. - "Installing PHP" is about which PHP version you want to install. According to the `Command`, the installing...

"patch for fix readline detection" is broken

Closed via #1357.

fix: Resolve build failure due to using OpenSSL@3 instead of [email protected] on macOS for PHP < 8.1

@driskell, thanks for your PR. If possible, could you provide your macOS environemt that you run this change? (e.g. Mac Mini M1) And I can reproduce the issue and verify...

fix: Resolve build failure due to using OpenSSL@3 instead of [email protected] on macOS for PHP < 8.1

Thanks for PR. This PR needs the macOS machine to be verified. Do you try to build the phpbrew with this PR to verify that?

fix: Resolve build failure due to using OpenSSL@3 instead of [email protected] on macOS for PHP < 8.1

Using the latest `PHPBrew version 2.2` and compiling the `PHP 8.0.30` version log is as follows: ```sh $ phpbrew --debug install 8.0.30 +mbstring +json +filter +openssl +zip +intl +xml +ctype...

fix: Resolve build failure due to using OpenSSL@3 instead of [email protected] on macOS for PHP < 8.1

@c9s, could you help me to review this PR? Thanks.

bad pattern issue with phpbrew in macos

Is there any steps to reproduce this issue?