Peter Gribanov

Constant value can be a array

22

Bug at [this](https://github.com/myclabs/php-enum/blob/master/src/Enum.php#L73) line. ([proof](http://php.net/manual/en/language.oop5.constants.php)) It will be better use the name of constant for `__toString()`.

The Dependency Inversion Principle

6

I add a Reader service interface to add the ability to [invert dependencies](https://en.wikipedia.org/wiki/Dependency_inversion_principle).

## Rad ``` public function newAction() { $post = new BlogPost; $form = $this->createBoundObjectForm($post, 'new'); if ($form->isBound() && $form->isValid()) { $this->persist($post, true); $this->addFlash('success'); return $this->redirectToRoute('app_blogposts_index'); } // is not a...

[Form] Add upgrade path for empty_data option in TextType

5

| Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | yes | License | MIT...

If it is possible to use a stream as a resource, then it is better to use it than callbacks. It will consume less resources.

Small optimization of getting name of the JSON error constant

1

We restrict the selection to only JSON category constants so as not to check all constants.

We declare as support Symfony 2.3 - 2.6, but this versions not support `Symfony\Component\Console\Style\SymfonyStyle` what we use.

``` $ app/console maxmind:geoip:update-data http://geolite.maxmind.com/download/geoip/database/GeoLiteCity.dat.gz "gunzip" ▒▒ ▒▒▒▒ ▒▒▒▒७▒▒▒ ▒▒▒ ▒▒▒譥▒ ▒▒▒▒▒▒▒▒, ▒ᯮ▒▒塞▒▒ ▒ணࠬ▒▒▒ ▒▒▒ ▒▒▒▒▒▒ 䠩▒▒▒. ``` Maybe it would be better not to use the [system function](https://github.com/aferrandini/Maxmind-GeoIp/blob/master/src/Maxmind/Bundle/GeoipBundle/Command/LoadDataCommand.php#L64) and...

Why not use the [original library](https://github.com/maxmind/geoip-api-php) as [lib](https://github.com/aferrandini/Maxmind-GeoIp/tree/master/src/Maxmind/lib)? The original library has methods for dealing with [time zones](https://github.com/maxmind/geoip-api-php/blob/master/src/geoipregionvars.php). The code of the original library is terrible, but your is not...