peter-csala

Results 54 comments of peter-csala

> I wonder if the suggested fix matches with the documentation here: https://github.com/App-vNext/Polly/wiki/Circuit-Breaker#half-open That page is covering the legacy V7 API. That works slightly differently than the V8 API. One...

☝🏻 seems a bit error-prone. Non-existing key overrides would result in `KeyNotFoundException`. Introducing hierarchical constants might be a better option IMHO. ```cs options.EventSeverityOverrides[TelemetryNames.RateLimiter.OnRejected] = ResilienceEventSeverity.Information; ```

> Constants or not, we wouldn't get exceptions because we'd use `TryGetValue()` not the indexer. If the `EventSeverityOverrides` is exposed as an `IDictionary` then you can not enforce the usage...

I tried to reproduce the issue in a console application. - When I run the application without the `ConfigureFunctionsWorkerDefaults` call then it works fine without any exception. - When I...

I've put together two simple unit tests. ```cs [Fact] public async Task ThrowNotHandledException() { //Arrange const int expectedRetryCount = 0; int actualRetryCount = 0; var context = ResilienceContextPool.Shared.Get(); var retry...

> @peter-csala Your example works by luck because the retry strategy does exception handling inside. if you added other strategy (custom for example) the test would fail. I did not...

I think we can agree on that the current situation is sub-optimal. Asking the caller via a documentation comment to wrap the exceptions into `Outcome` objects is not ideal. Even...

Hi Leonard, I've provided three slightly different implementation examples [here](https://stackoverflow.com/questions/59833373/refresh-token-using-polly-with-named-client) how to solve refresh token problem with Polly. Similar question as your has been asked at end of last year:...

> On next retry the `HttpClient` will contain the new header with token? The presented code itself yes it updates the related header in a way that the next attempt...