github-pr-helper icon indicating copy to clipboard operation
github-pr-helper copied to clipboard

Remove labels on the detailed view, as Github just added them

Open neurolit opened this issue 11 years ago • 5 comments

Hi!

Github just changed its discussion view (aka detailed view), and added the labels to it. Hence, with your extension, labels are displayed twice:

screenshot_130

This PR removes the modification of the detailed view, as it is not necessary anymore:

screenshot_131

Tests were updated, too.

neurolit avatar Jan 29 '14 22:01 neurolit

Thanks for your extension, BTW :-)

neurolit avatar Jan 29 '14 22:01 neurolit

Is the extension needed at all now? On 29 Jan 2014 22:55, "Florian D." [email protected] wrote:

Thanks for your extension, BTW :-)

Reply to this email directly or view it on GitHubhttps://github.com/petebacondarwin/github-pr-helper/pull/18#issuecomment-33641454 .

petebacondarwin avatar Jan 30 '14 06:01 petebacondarwin

I think so: it's really useful for the pull requests list. I don't understand why GH doesn't display labels on this page.

neurolit avatar Jan 30 '14 06:01 neurolit

OK. I'll merge today

... sent from my tablet On 30 Jan 2014 06:31, "Florian D." [email protected] wrote:

I think so: it's really useful for the pull requests list. I don't understand why GH doesn't display labels on this page.

Reply to this email directly or view it on GitHubhttps://github.com/petebacondarwin/github-pr-helper/pull/18#issuecomment-33663615 .

petebacondarwin avatar Jan 30 '14 07:01 petebacondarwin

:+1:

neurolit avatar Jan 30 '14 07:01 neurolit