bobby-tables icon indicating copy to clipboard operation
bobby-tables copied to clipboard

Switch to another module than File::Slurp

Open petdance opened this issue 7 years ago • 4 comments

File::Slurp will break under Perl 5.30. Switch to something else, if not just writing my own read_file.

petdance avatar Oct 25 '18 01:10 petdance

Hi @petdance , I wasn't sure whether eliminating a dependency entirely or clarity via retaining a dependency was the priority here, so I did it both ways. Or perhaps there is a door number three you had in mind? :)

dz-at-tc avatar Oct 04 '21 21:10 dz-at-tc

Hey @petdance , so none of the above, eh?

We could squirrel away the do/local/<> idiom ugliness like so...

sub read_file {
    return do {local(@ARGV, $/) = shift; <>};
}

... if that makes any difference?

dz-at-tc avatar Oct 08 '21 17:10 dz-at-tc

Hey @petdance , so none of the above, eh?

No, I just haven't had time to work on it yet. Other things have taken precedence. I appreciate the PR.

petdance avatar Oct 08 '21 17:10 petdance

Ahhh, but of course (in my best Grey Poupon :)

Apologies for the line noise.

dz-at-tc avatar Oct 08 '21 17:10 dz-at-tc