Petar Dambovaliev

Results 32 comments of Petar Dambovaliev

.m4a doesn't work, play button loads for a bit and nothing else happens. Any ideas?

> As a person with absolutely no honor or dignity, this is what I did: > > ```rust > use std::io::Read; > use tokio::{ > io::{AsyncRead, AsyncReadExt}, > runtime::Handle, >...

Macros for collections like `as_list` and `as_map` do not create the collections with the known length. This results in multiple unnecessary allocations.

It would be nice if the `UDF`s were not just strings but went through a macro that enforced the aerospike rules for `Lua`. It would bring runtime errors into compile...

Some functions' arguments have improper names, where `bin: &str` should actually be `bin_name: &str` or `udf_name: &str` where it should be `module: &str` or something like that. Naming is not...

> It would be nice if the `UDF`s were not just strings but went through a macro that enforced the aerospike rules for `Lua`. It would bring runtime errors into...

This enum was defined with the idea that there would be more than 1 language and possible additions in the future. However, with this definition, adding another variant is a...

`cargo check` produces an error ``` error: Please select a runtime from ['rt-tokio', 'rt-async-std'] --> aerospike-rt/src/lib.rs:2:1 | 2 | compile_error!("Please select a runtime from ['rt-tokio', 'rt-async-std']"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```

> Thanks for the review @petar-dambovaliev. I will take a look at your suggestions. > > > cargo check produces an error > > I know about that and this...

Seems like it's complicated and no user case currently.