pest-plugin-arch icon indicating copy to clipboard operation
pest-plugin-arch copied to clipboard

Allow usage of namespace selection using wildcards v2

Open naxvog opened this issue 1 year ago • 3 comments

See #12

Fixed the stan errors that resulted in the revert (https://github.com/pestphp/pest-plugin-arch/actions/runs/11094754954/job/30822574150)

edit:

  • added pipeline runs for commit prior to the revert

naxvog avatar Sep 30 '24 01:09 naxvog

Can you add a test like arch()->expect('*')->toUseStrictTypes();, and make that test pass?

nunomaduro avatar Sep 30 '24 07:09 nunomaduro

Added the strict types test

Output using the only method: image

naxvog avatar Sep 30 '24 13:09 naxvog

Added #17 to fix those PR checks

naxvog avatar Oct 01 '24 20:10 naxvog

@nunomaduro Does this PR need #17 to move forward ? :pray:

jambonfarci avatar Oct 25 '24 14:10 jambonfarci

I am considering forking and republishing on packagist in order to allow others to use this.

Will be a commitment to keep this up to date though ;)

naxvog avatar Nov 05 '24 16:11 naxvog

Haven't had time to test it properly but it should work: https://github.com/naxvog/pest-plugin-arch https://packagist.org/packages/naxvog/pest-plugin-arch

composer require --dev naxvog/pest-plugin-arch

naxvog avatar Nov 12 '24 14:11 naxvog

Haven't had time to test it properly but it should work: https://github.com/naxvog/pest-plugin-arch https://packagist.org/packages/naxvog/pest-plugin-arch

composer require --dev naxvog/pest-plugin-arch

What is the next step for this PR to be merged ?

jambonfarci avatar Jan 03 '25 16:01 jambonfarci

If you ask me, it can be merged immediately.

Edit: Keep in mind that the tests are failing for any PR because of a general test issue. I posted a fix for this in #17

naxvog avatar Jan 04 '25 08:01 naxvog

If you ask me, it can be merged immediately.

Edit: Keep in mind that the tests are failing for any PR because of a general test issue. I posted a fix for this in #17

Thanks for your reply !

@nunomaduro Any thoughts on this topic ? :pray:

jambonfarci avatar Jan 07 '25 22:01 jambonfarci