aikido icon indicating copy to clipboard operation
aikido copied to clipboard

ConcreteManipulator should be inheriting from ConcreteRobot?

Open gilwoolee opened this issue 5 years ago • 1 comments

Currently,

  • Manipulator inherits Robot
  • ConcreteRobot inherits Robot
  • ConcreteManipulator inherits Manipulator

the only difference between Manipulator and Robot is that Manipulator has getHand class. I think above inheritance makes sense conceptually, but code-wise, there's a lot of code duplicates between ConcreteManipulator and ConcreteRobot, esp. regarding TSR related methods.

I think we need to add ConcreteRobot to ConcreteManipulator's parent class list, i.e.

  • ConcreteManipulator inherits Manipulator and ConcretRobot

gilwoolee avatar Feb 25 '20 22:02 gilwoolee

@brianhou @aditya-vk @sniyaz @egordon Any thoughts?

gilwoolee avatar Feb 25 '20 22:02 gilwoolee

Resolved by the Robot API overhaul (#593 )

egordon avatar Dec 09 '22 22:12 egordon