persephone icon indicating copy to clipboard operation
persephone copied to clipboard

Published 20 hours ago • verified publisher icon persephone-tools

Write unit tests for all the pure functions.

Open oadams opened this issue 7 years ago • 4 comments

oadams avatar Feb 09 '18 00:02 oadams

I think related to this is changing some functions to take parameters that currently rely on global state.

shuttle1987 avatar Feb 13 '18 01:02 shuttle1987

Yeah, agreed.

oadams avatar Feb 13 '18 02:02 oadams

When you do this. Ignore for now run.py, results.py, and lattice.py and of course anything that is already covered by tests (see the coveralls page, as well as what is under pytest.mark.experiment tags in persephone/test/experiments/ as per #135).

I think related to this is changing some functions to take parameters that currently rely on global state.

Yes, this would be great. I think addressing this issue and #135 now is a good move as it can give you a chance to familiarize yourself with the functionality of the code and spot places to refactor and clean things up. This should be useful in guiding some of the API decisions we'll need to make soon when revisiting GUI stuff.

oadams avatar Mar 27 '18 02:03 oadams

#197 gets us closer to having test coverage of all the important paths. Might be good to round up the loose ends sometime soon.

shuttle1987 avatar Sep 15 '18 07:09 shuttle1987