persephone icon indicating copy to clipboard operation
persephone copied to clipboard

Remove dependency on sox to split/trim wave files

Open shuttle1987 opened this issue 6 years ago • 5 comments

If desired we could implement a pure python standard library only version of functions like trim_wav_ms by using the wave module https://docs.python.org/3/library/wave.html

shuttle1987 avatar Aug 01 '18 14:08 shuttle1987

That would be good but I agree with your labelling this low-priority. Calling sox for now is fine.

oadams avatar Aug 05 '18 16:08 oadams

I guess one thing is that sox may be a whole lot faster depending on how the standard library wave module is implemented. This might be a good first issue for someone to contribute?

shuttle1987 avatar Aug 05 '18 16:08 shuttle1987

Sure, since it's pretty orthogonal to everything else.

oadams avatar Aug 05 '18 17:08 oadams

It seems as though Kaldi needs sox anyway

shuttle1987 avatar Oct 21 '18 06:10 shuttle1987

I think this might be a situation where it makes sense to use this standard library function as a fallback only if sox is not available.

shuttle1987 avatar Nov 25 '18 10:11 shuttle1987