Perry Mitchell

Results 673 comments of Perry Mitchell

TLDR; (for newcomers) Setting up GCM would be ideal, but there's some huge items to tackle before that would be possible: * iocane would need GCM support * This library...

I'll try to add support to this soon..

I'd propose not using WebDAV here, as getting the ID/token seems tricky. Let's do a full OAuth integration in #302.

@SaidTorres3 Thanks for that! Your solution works perfectly. I went ahead and make a separate hook so it's easily reused wherever you create modal components: ```typescript import { useEffect, useState...

Hmm, interesting. I like the idea of cancelable requests, but I'm not particularly onboard with cancelable promises. Your proposal makes sense but if this were to go through I'd prefer...

I disagree - as mentioned in the PR the API of the client should not be dependent on the engine’s API. If I provide access to axios directly then I’m...

Well I think this is a bit dramatic for what I’m proposing, which is a simple function to control a single feature. I’m not discussing a request manager - this...

I appreciate the feedback and suggestion, and definitely see this as being a useful feature!

Hi @skjnldsv - Your point about try/catch is a good one, it does indeed make having the `cancel` method attached to the promise a difficult issue to solve. Ultimately it...

Well, we have an agreement! 😁 I'll see if I find time to add this soon, but if anyone else wants to implement it feel free. Please follow my example...