Perry Mitchell

Results 711 comments of Perry Mitchell

> Is all the BC form input button injection functionality in launch.js? Actually no, it comes from the index here: https://github.com/buttercup/buttercup-browser-extension/blob/master/source/tab/index.js#L37-L76 And the engine to run that is [locust](https://github.com/buttercup/locust), our...

> what do you make of Buttercup not ignoring hidden form inputs? Yeah, buttercup doesn't ignore hidden inputs. It should fetch all forms but the inputs that are used to...

> if some form input(s) exist/detected then don't show individual input buttons just show one generic call to action (e.g. located top right) This is a great idea! I'd entertain...

Yes, there's a refactoring of our login form detection on the horizon.. it won't require any particular elements like . It'll also supported nested iframes which is a huge problem...

The future is looking promising: ![image](https://user-images.githubusercontent.com/3869469/190496248-f1cdffa1-7f22-440a-980b-afdef44afbf0.png) (Reddit) ![image](https://user-images.githubusercontent.com/3869469/190496322-95bc5995-3ed6-45c9-9cd3-a1208e21ecbd.png) ![image](https://user-images.githubusercontent.com/3869469/190496411-e50c924e-e19d-446e-a5a8-daac6831c1e0.png) (DigitalOcean) Doing some testing and updates to the detection logic in prep for the new manifest v3 support. It should be...

@strump It looks nice! Not sure that it should really be in the list area with the search results.. I wonder if having another button beside the search input would...

You're right, it should close the tab. Thanks!

I hear you. The build process is the worst on mobile out of our apps, and could do with an improved configuration and update procedure. The issue I see is...

@neonmori It seems so :( - We recently updated our Dropbox client, so I'll file a bug over there. Apologies for the inconveniece!

Thanks for this, I'd consider a PR fixing these points of course..