Perry Mitchell comments

Results 673 comments of


                                            Perry Mitchell

Implicit flow not implemented

So this basically rules out this library when considering a secret-less sign-in process. If neither implicit grants or PKCE are supported.

[Authorization Code] - getClient method has dual role depending on which method is using.

The client secret should not be sent in the initial login request, as this would expose it in the URL/query string. It's only required for the token exchange which occurs...

Firefox snap has no access to /tmp profiles path

Any fix for this? Running into it in Karma+Firefox now, Ubuntu 22.04, Firefox 104.0.2: ![image](https://user-images.githubusercontent.com/3869469/189192526-6f5c35f7-f7b5-4c70-acf6-c8bc8067b930.png)

Pass callback to grunt.task.run

`writeFile` encoding has no effect any more

Well, now that I look at it, I'm not sure if there's any change needed. `webdav-fs` is meant to somewhat mimic the standard `fs` interface of Node, and Node requires...

mkdir: support for nodejs 10.x options.recursive (mkdir -p)

Sounds good to me! Happy to receive a PR for this. It's good that webdav by default uses the [recursive -> `false` (`MKCOL`) default behaviour](https://tech.yandex.com/disk/doc/dg/reference/mkcol-docpage/) that node implements. Not sure...

Allow appending when writing into files

This would probably depend on perry-mitchell/webdav-client#2

readdir includes parent path name when not mounted on root

Thanks for this! Unfortunately I don't have time right now to dig into it, but have you checked if your issue is reproducible on the parent `webdav` project? I'd also...

TypeError: he.decode is not a function

Can you provide the file or a simple example project? I’d need this to reproduce.

Auto-type feature

Imo this is not an ideal approach, as it would require the Desktop app to emit system-wide keyboard events.. right? Why not simply do the same with the browser extension?...