Julian Grinblat
Julian Grinblat
@pulmo thanks for the explanation! Finally it makes sense now :) Maybe I should send a PR mentioning this in `README.md` in case someone else stumbles into this problem?
+1, although I wonder, why do you not call `this.userhandler.onSuccess` if there is a callback? They aren't exclusive
Hm... In order to remain backwards compatible though, even if there is a callback, I think you should call the userhandler callbacks as well
@ottomao I resolved the conflicts and fixed the tests! Would be nice if you could review this, thanks!
Well of course that's the way to get this done for now. Actually, this is trivially easy to add using the technique: https://github.com/gulpjs/vinyl/pull/152 Without a whole ESM rewrite...
I'm still interested in this PR just in case 😄
It would be amazing if this landed!
Yeah, these kind of changes can be very tricky for sure, totally get cautious... but sooner or later I imagine this will need to be solved? As it stands it...
Slightly updated the exports to be more conservative and target the node environment explicitly. Please tell me if there's anything else I can do to move this forward!
`react` and `react-dom` load under `esm` without any issues. Even named exports work as expected. I think it's because of the work done on https://github.com/nodejs/cjs-module-lexer - node is doing static...