opal icon indicating copy to clipboard operation
opal copied to clipboard

Missing wget binary

Open ojecborec opened this issue 1 year ago • 4 comments

When running the latest permitio/opal-client:0.7.12 image as docker compose with following command

sh -c "exec ./wait-for.sh http://opal-server:7002/healthcheck --timeout=60 -- ./start.sh"

the ./start.sh script is never executed. The reason is that wget binary does not exists therefor

wget --timeout=1 -q "$HOST" -O /dev/null > /dev/null 2>&1

returns 127 exit code.

ojecborec avatar Sep 15 '24 06:09 ojecborec

/bounty $100

gemanor avatar Sep 18 '24 10:09 gemanor

💎 $100 bounty • Permit.io

Steps to solve:

  1. Start working: Comment /attempt #655 with your implementation plan
  2. Submit work: Create a pull request including /claim #655 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to permitio/opal!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @ojecborec Sep 18, 2024, 10:57:17 AM #662

algora-pbc[bot] avatar Sep 18 '24 10:09 algora-pbc[bot]

/attempt #655 https://github.com/permitio/opal/pull/662

Options

ojecborec avatar Sep 18 '24 10:09 ojecborec

@ojecborec @gemanor any progress on this issue?

Abiji-2020 avatar Oct 24 '24 16:10 Abiji-2020

@Abiji-2020 Still waiting for @obsd to help us with failing tests on #662

ojecborec avatar Oct 24 '24 16:10 ojecborec

@Abiji-2020 Still waiting for @obsd to help us with failing tests on #662

okay, incase if you need another hand, i am ready for it .

Abiji-2020 avatar Oct 24 '24 16:10 Abiji-2020

The log file reads

- Create .env file
- Clone tests policy repo to create test's branch
Cloning into 'opal-tests-policy-repo'...
Load key "/home/runner/work/opal/opal/app-tests/opal-tests-policy-repo-key": error in libcrypto
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

I've only added wget package to apt-get install statement. This fail seems to be unrelated to my change. Do you have any idea what is going on?

ojecborec avatar Oct 24 '24 16:10 ojecborec

The log file reads

- Create .env file
- Clone tests policy repo to create test's branch
Cloning into 'opal-tests-policy-repo'...
Load key "/home/runner/work/opal/opal/app-tests/opal-tests-policy-repo-key": error in libcrypto
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

I've only added wget package to apt-get install statement. This fail seems to be unrelated to my change. Do you have any idea what is going on?

I had checked several PR's in the repo and all of them has this issue, it is not a problem with the code, it is a problem with the docker workflow:

https://github.com/permitio/opal/blob/master/.github/workflows/tests.yml#117 the error is that issue with the SSH key used to clone the repository, which is likely caused by a missing or misconfigured SSH key.

Abiji-2020 avatar Oct 24 '24 16:10 Abiji-2020

Thank you for the explanation. Is there anything I can help with?

ojecborec avatar Oct 26 '24 05:10 ojecborec

Thank you for the explanation. Is there anything I can help with?

we can ask the maintainers to check on the secrets the correct values are given in the repository. As all the PR currently opened are facing this issue in the docker test.

Abiji-2020 avatar Oct 26 '24 06:10 Abiji-2020

Hey, we have an issue with the CI at the moment, some expired token of some sort. I'm waiting for someone else's help, hopefully I will be able to resolve it soon and get this merged 🌟

danyi1212 avatar Oct 26 '24 07:10 danyi1212

It is pending 1 reviewer at the moment.

ojecborec avatar Nov 05 '24 15:11 ojecborec

@danyi1212 do we want to merge it?

gemanor avatar Dec 13 '24 11:12 gemanor

you can modify the wait-for.sh script to use curl instead: Replace: wget --timeout=1 -q "$HOST" -O /dev/null > /dev/null 2>&1 With: curl --max-time 1 -s "$HOST" > /dev/null 2>&1

Vivek777-droid avatar Jan 25 '25 11:01 Vivek777-droid

This seems to be fixed already with this change https://github.com/permitio/opal/pull/706 as wget is now present in opal-client and opal-server images 0.7.15

andriusm avatar Jan 27 '25 10:01 andriusm

Closing in favor of #706.

ojecborec avatar Feb 24 '25 14:02 ojecborec