POST /data/config on OPAL client ignore the field save_method.

[loan75]

Describe the bug Currently the field save_method in the OPAL server API 'POST /data/config' is unused. No matter what we set, it will always perform the save_method PUT. https://github.com/permitio/opal/blob/master/packages/opal-client/opal_client/data/updater.py#L396

Expected behavior The field same_method should be used to determined how OPAL gonna push the data on OPA. At least, i want to implement the PATCH method. In fact, it's already in the code, we just need to use it in the updater (select the method based on the field save_method received). https://github.com/permitio/opal/blob/master/packages/opal-client/opal_client/policy_store/opa_client.py#L493

OPAL version

• Version: latest

[asafc]

Hi @loan75, welcome to our community!

This feature was not yet implemented correctly, i know @orishavit has done some work in this direction, but this is still WIP.

We will be sure to prioritize this after the holiday. If you can manage it, we welcome code contributions :)

[OancaAndrei]

Hi @asafc! I've stumbled upon this issue while experimenting with PATCH as save_method. Am I to understand that this issue is now resolved thanks to #483?

[orweis]

Hi @asafc! I've stumbled upon this issue while experimenting with PATCH as save_method. Am I to understand that this issue is now resolved thanks to #483?

Yes you understand correctly -this issue seems to be a duplicate and is closed by https://github.com/permitio/opal/pull/483