opal icon indicating copy to clipboard operation
opal copied to clipboard

Allow to use new version of tenacity

Open hongbo-miao opened this issue 2 years ago • 2 comments

Currently opal-common pins tenacity to version 6.3.1.

When we build the Docker image of our own fetcher based on opal-fetcher-postgres, it will show this error if we use new tenacity version

8.0.1 is installed but tenacity==6.3.1 is required by {'opal-common'}

It would be great to allow us to use new version in future. Thanks! 😃

hongbo-miao avatar Aug 28 '21 01:08 hongbo-miao

I do need to upgrade the versions of tenacity and other libraries required by opal. However it's a bit difficult because of inter-dependency constraints they have.

For example, as it stands, there is a coupling between opal dependencies and its lower level libraries dependencies - fastapi_websocket_pubsub and fastapi_websocket_rpc.

I can probably try to do it when we release the next version :)

asafc avatar Aug 28 '21 08:08 asafc

I think we can move to pin to a minimum (non major) version instead of an exact version; for stable packages like tenacity and FastApi. Though in this case of Tenacity it wouldn't have helped since it changed via two major versions [6 to 8] (with possibly breaking changes)

orweis avatar Aug 28 '21 18:08 orweis