fastapi_websocket_rpc icon indicating copy to clipboard operation
fastapi_websocket_rpc copied to clipboard

unnecessary dependency to uvicorn

Open WisniewskiP opened this issue 2 years ago • 1 comments

I think uvicorn could be removed from requirements as it add unneeded dependencies on client side.

fastapi package can be used with uvicorn but doesn't add explicit dependency to it.

$ pip show fastapi
Name: fastapi
Version: 0.95.1
Summary: FastAPI framework, high performance, easy to learn, fast to code, ready for production
Home-page:
Author:
Author-email: Sebastián Ramírez <[email protected]>
License:
Location: c:\users\pawelwisniewski\executionplatform\ep\venv-3.10\lib\site-packages
Requires: pydantic, starlette

WisniewskiP avatar Sep 05 '23 08:09 WisniewskiP

Hi @WisniewskiP - I think you're right - though I'll ask for someone on the team to quickly review to be on the safe side.

orweis avatar Sep 06 '23 11:09 orweis