fastapi_websocket_pubsub icon indicating copy to clipboard operation
fastapi_websocket_pubsub copied to clipboard

Optional dependencies - Broadcaster Postgres dependency problem

Open operatorequals opened this issue 2 years ago • 1 comments

Hello people! First and foremost, I really appreciate your project! I am also using it heavily in a library I am making - eventhive.

So, I am trying to use your fastapi PubSub in a project that cannot use compiled C extensions.

This wouldn't be a problem as fastapi is Python, but broadcaster does require a postgres dependency that contains C code, failing my build.

I propose to create optional dependencies, exactly like broadcaster does, so I can exclude the postgres dependency that creates the issue - I'm not planning to use postgres anyway!

Thanks again for your project, it really is very useful!

operatorequals avatar Apr 01 '23 17:04 operatorequals

HI @operatorequals :) Thanks for reaching out and for the kind words :) Eventhive sounds cool, and I'm happy our Pub/Sub impl. helps you there.

Sure, you can go ahead an open a PR to have that as part of the setup.py / requirements.txt ; please include a "default" or "all" option that will install all the dependencies as now, and one for each of the potential targets (e.g. postgres, redis, ... )

@roekatz or I will review and approve :)

orweis avatar Apr 02 '23 08:04 orweis