App-Spec-p5 icon indicating copy to clipboard operation
App-Spec-p5 copied to clipboard

It could use more of Moo

Open dakkar opened this issue 8 years ago • 2 comments

Looking at the source code, I notice that in a few places you're not exploiting the facilities that Moo provides (e.g. you've got common and build do more-or-less what BUILDARGS and BUILD are designed to do, you handle lazy attributes by hand, you have no type constraints). Is there a particular reason for that, or is just general unfamiliarity with Moo? Would it be appreciated if I sent a pull request making the whole thing more Moo-ish? I'd also like to add some type constraints via Type::Tiny, but that can come later.

dakkar avatar Dec 29 '16 16:12 dakkar

yeah, i'm not familiar enough with Moo and did it the old school manual way so far. I have been refactoring a lot and I hope I have to do less in the future. Would be glad about a PR! I also wanted to add type constraints someday =)

perlpunk avatar Dec 29 '16 16:12 perlpunk

I'll get started, then ☺

dakkar avatar Dec 29 '16 16:12 dakkar