life icon indicating copy to clipboard operation
life copied to clipboard

Question: Is life available without Go modules?

Open hajimehoshi opened this issue 7 years ago • 3 comments

As life uses replace section in its go.mod, I was wondering if life works when the user tries to go-get github.com/go-interpreter/wagon instead of github.com/perlin-network/wagon due to lack of Go modules.

hajimehoshi avatar Dec 14 '18 12:12 hajimehoshi

It looks like there are some API differences and I couldn't go-get without Go modules:

$ GO111MODULES=off go get -u github.com/perlin-network/life
# github.com/perlin-network/life/compiler
go/src/github.com/perlin-network/life/compiler/module.go:153:31: too many arguments in call to disasm.Disassemble
        have (wasm.Function, *wasm.Module)
        want ([]byte)
go/src/github.com/perlin-network/life/compiler/module.go:157:39: cannot use d (type []disasm.Instr) as type *disasm.Disassembly in argument to NewSSAFunctionCompiler

I feel like replace usage in go.mod is weird since this changes some public API without changing the package paths. I couldn't find such replace usage at Wiki https://github.com/golang/go/wiki/Modules#when-should-i-use-the-replace-directive. Would it be possible not to use replace usage in the go.mod?

hajimehoshi avatar Dec 14 '18 12:12 hajimehoshi

friendly ping

hajimehoshi avatar Dec 27 '18 20:12 hajimehoshi

the broken modules support is making upgrades quite painful.

Would you mind git tagging some releases?

silasdavis avatar Oct 08 '19 21:10 silasdavis