DBD-MariaDB icon indicating copy to clipboard operation
DBD-MariaDB copied to clipboard

Refactor of parse_dsn()

Open rkleemann opened this issue 5 years ago • 3 comments

Use this in place of #132 or #143

rkleemann avatar Mar 20 '19 16:03 rkleemann

It seems the new test is missing in the manifest.

choroba avatar Mar 21 '19 09:03 choroba

Also, you have opened this change in 3 different pull requests. Please update code in existing pull request and do not open new one. One change with whole review should be in one pull request.

pali avatar Mar 21 '19 10:03 pali

@rkleemann could you fix the issues mentioned above in the review?

pali avatar Aug 26 '23 21:08 pali