periodo-client icon indicating copy to clipboard operation
periodo-client copied to clipboard

Minor UI change to patch review page

Open atomrab opened this issue 4 years ago • 2 comments

This really only affects me at the moment, but if we ever manage to form an editorial college, it might be a bigger deal, so if the fix is simple, probably worth doing.

In various pages in the client, a positive action (add, update, save) is marked with a blue button, a negative one with a red button; in some pages, the blue action is on the left (this is what I would normally expect, if the positive is the default), although on the edit period page the red actions are on the left.

On the patch review page, the red "reject" button is on the left, right under the field title, and the "accept" button is gray and on the right. At least once, I wasn't paying attention and just clicked on the most visible button on the page when I meant to accept a patch -- but it was the reject button.

I would suggest that we turn the accept button blue, at the least, and maybe consider moving it (and all positive actions?) over the left-hand side of the page, with negative actions on the right. This would help avoid accidental rejections, which currently require us to contact the rejectees and ask them to resubmit.

I do recognize that accidental approvals are more problematic, since then we have data that have entered the main dataset and might be used before they can be purged. But maybe a better solution to this is an "Are you sure you want to approve" warning pop-up or page?

As long as I'm mainly handling this, I'll just pay better attention (this hasn't happened to me since the first time). But once we have more people involved, we should be aware that this might elevate the rate of accidental rejections.

atomrab avatar Sep 04 '20 13:09 atomrab