GetCountries icon indicating copy to clipboard operation
GetCountries copied to clipboard

important feature CALLING Country Code

Open syrakozz opened this issue 9 years ago • 5 comments

thank you for the amasing work you have done, can you plz add the CALLING Country Code like lebanon 961 you can grab them from this site http://countrycode.org/

syrakozz avatar Oct 08 '14 09:10 syrakozz

I suppose REST Countries would be a better fit, but, @peric , here's an issue:

should we change the GetCountries project, in order to completely consume the API that I fore-mentioned, or would you like to adjust the call to the geonames API, to the current need?

Here are two points:

  1. The first one will make the feature that this issue refers to, easier, but requires enough modifications in the current source, I guess.
  2. The second option leaves the current source as is, but has to cleverly combine it with the required "calling country code" fetching from the external API; this also means that we will have two calls to external services.

What's your opinion?

teobais avatar May 23 '15 02:05 teobais

@toubou91, cool ideas...

At the moment, I'm still rewriting current application to use react.js (#24). I got stuck a bit because of other obligations but I think I'll finish this sometimes this week.

Sometimes after that, we can maybe do additional refactoring and use REST countries instead of Geonames, I would just need to check whether all the existing fields can be fetched from there.

So, let's talk after I finish #24 and merge it to master

peric avatar May 25 '15 18:05 peric

+1, maybe no.1 is better

syrakozz avatar May 26 '15 07:05 syrakozz

Ok, I see that a full refactoring sounds better, to both of you.

Ok @peric, take your time and we 'll talk again soon (, as I have written down some points that need to be clarified, if you finally go for the REST Countries).

Good luck!

teobais avatar May 26 '15 12:05 teobais

Maybe this is an interesting subject for you again? Now when the "rectification" is done.

peric avatar Nov 10 '15 22:11 peric