gdnet3 Replaced `ERR_EXPLAIN` with `CRASH_NOW

Replaced `ERR_EXPLAIN` with `CRASH_NOW_MSG` for 3.2.1 compatibility

Open yeslayla opened this issue 4 years ago • 3 comments

Replaced error messaging functions to allow GDNet3 to build for Godot 3.2.1

Related Godot PR: https://github.com/godotengine/godot/pull/33517

Apr 20 '20 01:04 yeslayla

Will it not be better when we use ERR_FAIL_COND_V_MSG and ERR_FAIL_COND_MSG instead of CRASH_NOW_MSG?

Jan 23 '21 08:01 demurzasty

Will it not be better when we use ERR_FAIL_COND_V_MSG and ERR_FAIL_COND_MSG instead of CRASH_NOW_MSG?

It would probably be a better solution, though this PR is about a year old now, so I'm not sure how stale it is.

Jan 27 '21 15:01 yeslayla

Updated commit, implements changes suggested by @demurzasty and makes the project compatible with stable and 3.3rc

Apr 19 '21 04:04 yeslayla