cli icon indicating copy to clipboard operation
cli copied to clipboard

Add flag to build:approve to suppress 'approve action is already performed on this build' error

Open danieldelacruz01 opened this issue 4 months ago • 6 comments

Add flag to build:approve command to optionally prevent exiting with an error when the build already has approval.

I have opened a pull request that adds this functionality https://github.com/percy/cli/pull/1963 Image

Use case: in some instances we create and subsequently auto-approve Percy builds using the build:approve command in our GitHub workflows to satisfy a requirement for an approved Percy build in order to merge. In these instances we don't really care whether the build has already been approved.

danieldelacruz01 avatar Aug 20 '25 03:08 danieldelacruz01

@danieldelacruz01 Pr does look good in initial look. We will look into this and get back on this

prklm10 avatar Aug 20 '25 14:08 prklm10

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Sep 09 '25 19:09 github-actions[bot]

Not stale. The PR is awaiting a second round of reviews

danieldelacruz01 avatar Sep 09 '25 21:09 danieldelacruz01

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Oct 07 '25 19:10 github-actions[bot]

still awaiting reviews

danieldelacruz01 avatar Oct 08 '25 02:10 danieldelacruz01

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Oct 28 '25 19:10 github-actions[bot]

awaiting QA approval

danieldelacruz01 avatar Nov 13 '25 03:11 danieldelacruz01