cli icon indicating copy to clipboard operation
cli copied to clipboard

Add flag to ignore previous approvals on build:approve command

Open danieldelacruz01 opened this issue 4 months ago • 7 comments

Add flag --pass-if-previously-approved to build:approve command to optionally prevent exiting with an error when the build already has approval. Image

danieldelacruz01 avatar Aug 20 '25 02:08 danieldelacruz01

@danieldelacruz01 Thanks for your contribution and I see why you might need that flag. I have added some comments on the PR. You can check the failing specs from the lint and build and fix it if you wish. If you want percy team to have a look at it instead please raise a support ticket with browserstack and we would get it fixed.

ninadbstack avatar Aug 25 '25 08:08 ninadbstack

@ninadbstack thanks for the feedback. I've pushed a commit that should resolve the test and lint issues. Let me know if there's anything else you need.

danieldelacruz01 avatar Aug 25 '25 23:08 danieldelacruz01

@danieldelacruz01 added some comments

this-is-shivamsingh avatar Aug 27 '25 17:08 this-is-shivamsingh

This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Sep 16 '25 19:09 github-actions[bot]

@ninadbstack @this-is-shivamsingh Could you give this another review please, when you have a minute?

danieldelacruz01 avatar Sep 17 '25 00:09 danieldelacruz01

  • LGTM on the PR
  • We are waiting on QA bandwidth to test and give GTG for merging it, we are expecting to merge it by this month
  • Thank you @danieldelacruz01 for making this change, will be try to make it go in stable release asap

this-is-shivamsingh avatar Oct 09 '25 07:10 this-is-shivamsingh

This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Oct 28 '25 19:10 github-actions[bot]

Awaiting QA approval

danieldelacruz01 avatar Nov 13 '25 03:11 danieldelacruz01

Hey, @danieldelacruz01, thank you for your patience.

  • We will be starting the QA on this, soon this week or most probably next. Post that we will merge this. Sorry for the delay happening here, we will be prioritising this PR

this-is-shivamsingh avatar Nov 17 '25 05:11 this-is-shivamsingh