pmm icon indicating copy to clipboard operation
pmm copied to clipboard

[feature] add --force (or similar) to 'pmm-admin add'

Open brevilo opened this issue 1 year ago • 3 comments

Description

More often than not tools like PMM get deployed non-interactively nowadays, using tools like Saltstack. These typically use state descriptions for the configurations they manage. It would be helpful if pmm-admin would be designed in such a way, that its commands can be used repeatedly (idempotent) to ensure a desired config state is effective. For instance, calling pmm-admin add isn't idempotent as it fails when the service to be added already exists.

Suggested solution

One way to implement this would be to add a --force option that doesn't fail if the service exists but, if anything, updates its config. That is, unless a real error occurs. That should of course still return a non-zero value and some useful message on stderr.

Additional context

Have a look at pmm-admin config which has a --force option to simply allow repeated calls and returns a 0, unless a real error occurs.

Ideally all config-changing commands would allow such use.

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

brevilo avatar Aug 01 '24 13:08 brevilo

Hi @brevilo, idea looks good to us. We will add it to our Jira to track it.

BupycHuk avatar Aug 07 '24 08:08 BupycHuk

Thanks. This feature is crucial for us since it blocks rolling out PMM for a larger test. Please add a cross-reference as soon as you have it (couldn't find it yet), so I can track its progress 👍

brevilo avatar Aug 30 '24 10:08 brevilo

Just checking in again to make sure this doesn't get lost: @BupycHuk, where can I find the associated Jira issue?

Thanks

brevilo avatar Mar 07 '25 13:03 brevilo