pmm icon indicating copy to clipboard operation
pmm copied to clipboard

PMM-13095 Remove trimming of slowlog query IDs.

Open JiriCtvrtka opened this issue 9 months ago • 2 comments

PMM-13095

JiriCtvrtka avatar May 02 '24 15:05 JiriCtvrtka

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 44.33%. Comparing base (9209769) to head (b70b7b9).

Files Patch % Lines
agent/agents/mysql/slowlog/slowlog.go 71.42% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2984      +/-   ##
==========================================
- Coverage   44.36%   44.33%   -0.04%     
==========================================
  Files         368      368              
  Lines       35327    35333       +6     
==========================================
- Hits        15674    15666       -8     
- Misses      18042    18055      +13     
- Partials     1611     1612       +1     
Flag Coverage Δ
agent 52.59% <71.42%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 02 '24 15:05 codecov[bot]

I kept MD5 hashing and not switched for SHA etc since it is ideal length (32 chars) without trimming and this corresponds with Perfschema MySQL DIGEST (query ID).

JiriCtvrtka avatar May 03 '24 07:05 JiriCtvrtka