pmm icon indicating copy to clipboard operation
pmm copied to clipboard

[Proposal] PMM-7 Updade year in license headers

Open artemgavrilov opened this issue 10 months ago • 5 comments

PMM-7

artemgavrilov avatar Apr 22 '24 15:04 artemgavrilov

@artemgavrilov IMO this is not necessary, since the meaning of the year in copyrights is "Since [year] up to now".

Therefore, the repo files will bear that license until it changes, which is when we should update the year. If there is no intention to change the license, we can leave the year as is.

ademidoff avatar Apr 22 '24 16:04 ademidoff

@artemgavrilov IMO this is not necessary, since the meaning of the year in copyrights is "Since [year] up to now".

Therefore, the repo files will bear that license until it changes, which is when we should update the year.

Hm, I barely remember that we discussed what to do with the year and I thought that we agreed to update it. I am mistaken and we agreed to not touch year, shouldn't in be 2017 then (year when PMM project started)?

artemgavrilov avatar Apr 22 '24 16:04 artemgavrilov

@artemgavrilov IMO this is not necessary, since the meaning of the year in copyrights is "Since [year] up to now". Therefore, the repo files will bear that license until it changes, which is when we should update the year.

Hm, I barely remember that we discussed what to do with the year and I thought that we agreed to update it. I am mistaken and we agreed to not touch year, shouldn't in be 2017 then (year when PMM project started)?

In theory we could put 2017 in there, but I don't see much value added.

Anyway, even if there was a theoretical benefit, in my opinion it would just not be worth the effort of:

  • touching 750+ files
  • dealing with conflicts in v3

ademidoff avatar Apr 23 '24 07:04 ademidoff

@artemgavrilov IMO this is not necessary, since the meaning of the year in copyrights is "Since [year] up to now". Therefore, the repo files will bear that license until it changes, which is when we should update the year.

Hm, I barely remember that we discussed what to do with the year and I thought that we agreed to update it. I am mistaken and we agreed to not touch year, shouldn't in be 2017 then (year when PMM project started)?

In theory we could put 2017 in there, but I don't see much value added.

Anyway, even if there was a theoretical benefit, in my opinion it would just not be worth the effort of:

* touching 750+ files

* dealing with conflicts in v3

Up to PMM team to decide, that's just a proposal.

Regarding approaches, PostgreSQL for example updates headers yearly: https://github.com/postgres/postgres/commit/29275b1d177096597675b5c6e7e7c9db2df8f4df

If we will stick with 2023 over time it may look weird.

artemgavrilov avatar Apr 23 '24 12:04 artemgavrilov

@BupycHuk @ademidoff Folks, I'm leaving this up to you to decide what to do. I'm ok with any option.

artemgavrilov avatar Apr 23 '24 12:04 artemgavrilov

Closing this for now, will revisit once we stop maintaining v2.

ademidoff avatar May 21 '24 05:05 ademidoff