pmm icon indicating copy to clipboard operation
pmm copied to clipboard

PMM-12895 Add metrics resolutions configuration to agents

Open artemgavrilov opened this issue 11 months ago • 2 comments

PMM-12895

Link to the Feature Build: SUBMODULES-3578

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • [ ] API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

artemgavrilov avatar Mar 07 '24 17:03 artemgavrilov

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.29%. Comparing base (09f3823) to head (0261fd9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2882      +/-   ##
==========================================
- Coverage   43.34%   43.29%   -0.06%     
==========================================
  Files         399      399              
  Lines       41516    41429      -87     
==========================================
- Hits        17996    17937      -59     
+ Misses      21514    21488      -26     
+ Partials     2006     2004       -2     
Flag Coverage Δ
admin 11.61% <ø> (-0.06%) :arrow_down:
agent 52.83% <ø> (ø)
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 07 '24 17:03 codecov[bot]

LGTM, can we add a new test to scrape_configs_test with custom metrics resolution?

Functions from scrape_configs.go accept metrics resolutions as a parameter, so it doesn't matter from where it comes.

artemgavrilov avatar Mar 13 '24 13:03 artemgavrilov