pmm icon indicating copy to clipboard operation
pmm copied to clipboard

PMM-11280 Uninstall pmm client

Open anton-bystrov opened this issue 2 years ago • 3 comments

PMM-11280 After purge there are some files stayed in system - /usr/sbin pmm-agent and pmm-admin, pmm directory. This PR remove its.

anton-bystrov avatar Dec 22 '22 11:12 anton-bystrov

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8a7f0c9) 43.50% compared to head (f43a439) 43.52%. Report is 968 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1526      +/-   ##
==========================================
+ Coverage   43.50%   43.52%   +0.02%     
==========================================
  Files         368      368              
  Lines       43601    43601              
==========================================
+ Hits        18967    18977      +10     
+ Misses      22964    22953      -11     
- Partials     1670     1671       +1     
Flag Coverage Δ
admin 10.00% <ø> (ø)
agent 53.54% <ø> (+0.12%) :arrow_up:
managed 45.02% <ø> (-0.01%) :arrow_down:
vmproxy 70.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 22 '22 11:12 codecov[bot]

@anton-bystrov I'm not sure we should remove the config though. I may be of relevance even if the user decides to remove the deb package. rm -f /usr/local/percona/pmm2/config/pmm-agent.yaml

@BupycHuk, @denisok Do you guys have an opinion?

ademidoff avatar Dec 23 '22 13:12 ademidoff

@anton-bystrov I'm not sure we should remove the config though. I may be of relevance even if the user decides to remove the deb package. rm -f /usr/local/percona/pmm2/config/pmm-agent.yaml

@BupycHuk, @denisok Do you guys have an opinion?

I think if you run "purge" than you want remove all files from this package. And this is reason why suggest this changes.

anton-bystrov avatar Dec 23 '22 13:12 anton-bystrov