pmm icon indicating copy to clipboard operation
pmm copied to clipboard

PMM-10231 Credentials source

Open pkadej opened this issue 2 years ago • 2 comments

PMM-10231

Build: SUBMODULES-2719

pkadej avatar Aug 01 '22 20:08 pkadej

Codecov Report

Merging #1110 (8f254ae) into main (6ef119b) will decrease coverage by 0.08%. The diff coverage is 21.37%.

@@            Coverage Diff             @@
##             main    #1110      +/-   ##
==========================================
- Coverage   43.32%   43.23%   -0.09%     
==========================================
  Files         349      349              
  Lines       40777    40905     +128     
==========================================
+ Hits        17665    17685      +20     
- Misses      21586    21690     +104     
- Partials     1526     1530       +4     
Flag Coverage Δ
admin 8.71% <0.00%> (+0.11%) :arrow_up:
agent 54.26% <70.68%> (+0.05%) :arrow_up:
managed 44.46% <4.38%> (-0.26%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
admin/commands/management/add_external.go 3.70% <0.00%> (+0.67%) :arrow_up:
...min/commands/management/add_external_serverless.go 0.00% <0.00%> (ø)
admin/commands/management/add_haproxy.go 4.25% <0.00%> (+0.86%) :arrow_up:
admin/commands/management/add_mongodb.go 9.63% <0.00%> (+1.30%) :arrow_up:
admin/commands/management/add_mysql.go 24.21% <0.00%> (-1.20%) :arrow_down:
admin/commands/management/add_postgresql.go 0.00% <0.00%> (ø)
admin/commands/management/add_proxysql.go 0.00% <0.00%> (ø)
agent/client/channel/channel.go 59.58% <0.00%> (ø)
agent/commands/run.go 0.00% <0.00%> (ø)
managed/cmd/pmm-managed/main.go 0.00% <0.00%> (ø)
... and 11 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 01 '22 20:08 codecov[bot]

I had to regenerate descriptor.bin, because unused "ParseDefaultsFile" fields in agent API was renamed.

bin/buf breaking --against descriptor.bin api
api/agentpb/agent.proto:1:1:Previously present message "ParseDefaultsFileRequest" was deleted from file.
api/agentpb/agent.proto:1:1:Previously present message "ParseDefaultsFileResponse" was deleted from file.
api/agentpb/agent.proto:694:5:Field "20" with name "parse_credentials_source" on message "AgentMessage" changed option "json_name" from "parseDefaultsFile" to "parseCredentialsSource".
api/agentpb/agent.proto:694:5:Field "20" on message "AgentMessage" changed type from "agent.ParseDefaultsFileResponse" to "agent.ParseCredentialsSourceResponse".
api/agentpb/agent.proto:694:36:Field "20" on message "AgentMessage" changed name from "parse_defaults_file" to "parse_credentials_source".
api/agentpb/agent.proto:726:5:Field "18" with name "parse_credentials_source" on message "ServerMessage" changed option "json_name" from "parseDefaultsFile" to "parseCredentialsSource".
api/agentpb/agent.proto:726:5:Field "18" on message "ServerMessage" changed type from "agent.ParseDefaultsFileRequest" to "agent.ParseCredentialsSourceRequest".
api/agentpb/agent.proto:726:35:Field "18" on message "ServerMessage" changed name from "parse_defaults_file" to "parse_credentials_source".

pkadej avatar Sep 09 '22 22:09 pkadej

Feel free to merge without waiting for my approval, just make sure that it was QA-ed

BupycHuk avatar Oct 24 '22 21:10 BupycHuk

This ticket has been converted to draft until Przemyslaw researches PMM-10909 - whether it can replace code in this PR.

michal-kralik avatar Oct 27 '22 12:10 michal-kralik