percona
K8SPXC-1636 Fixed incorrect quoting in env command for copy_files_xbc…
Pull Request is related to Issue https://github.com/percona/percona-xtradb-cluster-operator/issues/1727
Jira Issue: https://perconadev.atlassian.net/browse/K8SPXC-1636
This Pull Request addresses incorrect quoting in the env command within the copy_files_xbcloud() function. The original implementation mishandled variable separation, leading to potential issues during execution. The updated code ensures proper handling of CREDENTIALS and xbcloud variables, improving compatibility and reliability.
Changes Made:
Fixed the quoting in the env command to prevent errors with variable interpretation.
Adjusted the structure of the copy_files_xbcloud() function for better execution consistency.
Impact: This fix improves the stability of the function and resolves issues related to incorrect variable handling during file downloading processes.
| Test Name | Result | Time |
|---|---|---|
| affinity-8-0 | passed | 00:05:43 |
| auto-tuning-8-0 | passed | 00:17:50 |
| cross-site-8-0 | passed | 00:31:49 |
| custom-users-8-0 | passed | 00:10:31 |
| demand-backup-cloud-8-0 | passed | 00:55:14 |
| demand-backup-encrypted-with-tls-8-0 | passed | 00:43:32 |
| demand-backup-8-0 | passed | 00:40:03 |
| demand-backup-flow-control-8-0 | passed | 00:09:44 |
| demand-backup-parallel-8-0 | passed | 00:08:42 |
| demand-backup-without-passwords-8-0 | passed | 00:15:45 |
| haproxy-5-7 | passed | 00:13:00 |
| haproxy-8-0 | passed | 00:12:52 |
| init-deploy-5-7 | passed | 00:15:13 |
| init-deploy-8-0 | passed | 00:16:09 |
| limits-8-0 | passed | 00:11:37 |
| monitoring-2-0-8-0 | passed | 00:21:47 |
| monitoring-pmm3-8-0 | passed | 00:17:01 |
| one-pod-5-7 | passed | 00:14:20 |
| one-pod-8-0 | passed | 00:14:30 |
| pitr-8-0 | passed | 00:44:20 |
| pitr-gap-errors-8-0 | passed | 00:53:22 |
| proxy-protocol-8-0 | passed | 00:09:01 |
| proxysql-sidecar-res-limits-8-0 | passed | 00:08:06 |
| pvc-resize-5-7 | passed | 00:13:28 |
| pvc-resize-8-0 | passed | 00:15:27 |
| recreate-8-0 | passed | 00:16:07 |
| restore-to-encrypted-cluster-8-0 | passed | 00:24:56 |
| scaling-proxysql-8-0 | passed | 00:07:55 |
| scaling-8-0 | passed | 00:10:10 |
| scheduled-backup-5-7 | failure | 00:34:42 |
| scheduled-backup-8-0 | passed | 01:01:11 |
| security-context-8-0 | passed | 00:25:58 |
| smart-update1-8-0 | passed | 00:31:10 |
| smart-update2-8-0 | failure | 00:28:24 |
| storage-8-0 | passed | 00:10:01 |
| tls-issue-cert-manager-ref-8-0 | passed | 00:08:24 |
| tls-issue-cert-manager-8-0 | passed | 00:11:08 |
| tls-issue-self-8-0 | passed | 00:12:44 |
| upgrade-consistency-8-0 | passed | 00:12:38 |
| upgrade-haproxy-5-7 | passed | 00:22:16 |
| upgrade-haproxy-8-0 | passed | 00:22:20 |
| upgrade-proxysql-5-7 | passed | 00:17:23 |
| upgrade-proxysql-8-0 | passed | 00:14:22 |
| users-5-7 | failure | 00:17:00 |
| users-8-0 | passed | 00:24:13 |
| validation-hook-8-0 | passed | 00:01:25 |
| We run 46 out of 46 | 15:33:54 |
commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/2058/commits/299906e848ae14b08434cf8e8287cd11dd7f2e74
image: perconalab/percona-xtradb-cluster-operator:PR-2058-299906e8
Hello @dbazhenov , given that we have also this PR: https://github.com/percona/percona-xtradb-cluster-operator/pull/2160 which is solving the issue you are handling here as well as another one, we suggest we close this PR and merge the aforementioned one. Thanks a lot!
