percona-xtradb-cluster-operator
percona-xtradb-cluster-operator copied to clipboard
percona
Remove max cluster name length validation
22 characters is exceptionally short for a Kubernetes resource name so unless there's a specific reason why a PXC cluster name can't be longer than 22 characters it shouldn't be enforced.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Nick Barber seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Nick Barber seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
22 characters
Did you check it? Unfortunately it is not so easy to improve it :(
We use 'cluster name' + '-pxc' suffix for wsrep_cluster_name option and for garbd group (for backups). If we set 32 characters for cluster name, we need to cut 4 characters in case of wsrep_cluster_name and garbd group options (because wee need to add additional '-pxc' suffix ). In this case we can face the situation when user can set cluster name for different clusters which will differ in these 4 characters at the end of cluster name and we will have issue in this case. So we decided to use unique hash for wsrep_cluster_name and 'garbd group' options but we can not do it till PSO 2.0 to avoid issues during the update. This issue will be fixed in our new PS operator.
Did you check it?
I did not test it. I was hoping to find out what the implications of this change would be.
We use 'cluster name' + '-pxc' suffix for wsrep_cluster_name option and for garbd group (for backups)
Where is this done in code? Just out of curiosity.
This issue will be fixed in our new PS operator.
By PSO do you mean https://github.com/percona/percona-server-mysql-operator? If so - what's the difference between this and that?
| Test name | Status |
|---|---|
| storage | passed |
| recreate | passed |
| self-healing | passed |
| restore-to-encrypted-cluster | passed |
| upgrade-haproxy | passed |
| self-healing-chaos | failed |
| haproxy | passed |
| big-data | passed |
| cross-site | passed |
| scaling | passed |
| demand-backup | passed |
| scheduled-backup | passed |
| scaling-proxysql | passed |
| init-deploy | failed |
| pitr | passed |
| security-context | passed |
| upgrade-proxysql | passed |
| smart-update | passed |
| upgrade-consistency | passed |
| self-healing-advanced | passed |
| self-healing-advanced-chaos | failed |
| limits | passed |
| monitoring-2-0 | failed |
| operator-self-healing | passed |
| operator-self-healing-chaos | failed |
| demand-backup-encrypted-with-tls | passed |
| affinity | passed |
| one-pod | passed |
| auto-tuning | passed |
| proxysql-sidecar-res-limits | passed |
| users | passed |
| tls-issue-self | passed |
| tls-issue-cert-manager | passed |
| tls-issue-cert-manager-ref | passed |
| validation-hook | failed |
| proxy-protocol | passed |
| We run 36 out of 36 |
commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1182/commits/50e0b2d624cf6b1ecd9b86726b63fbbc500c9b66
image: perconalab/percona-xtradb-cluster-operator:PR-1182-50e0b2d6
@njbarber I'm closing this PR since removing this limitation is not possible (it's a limitation of PXC).
