percona-toolkit icon indicating copy to clipboard operation
percona-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon percona

Fix --check-slave-lag (PT-178)

Open dveeden opened this issue 8 years ago • 5 comments
trafficstars

https://jira.percona.com/browse/PT-178

dveeden avatar Jul 27 '17 12:07 dveeden

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 27 '17 12:07 CLAassistant

Related to https://github.com/percona/percona-toolkit/pull/119

dveeden avatar Jul 27 '17 12:07 dveeden

Hey! This PR sound would be super useful, what stops you from merging? :-)

bartoszcisek avatar Jul 12 '19 10:07 bartoszcisek

I also would like to get this merged. I don't remember if there were any outstanding issues with this PR. Until this is fixed I'll use the last version that still has this functionality

dveeden avatar Jul 12 '19 11:07 dveeden

Hi,

Thanks for submitting this fix. I ran the tests and it breaks t/pt-online-schema-change/slave_lag.t. Could you please check it?

Thanks

percona-csalguero avatar Jul 17 '19 14:07 percona-csalguero

By now there are quite a few non-trivial conflicts. I also currently don't have good of (re)testing these changes.

dveeden avatar Sep 16 '22 06:09 dveeden