percona-toolkit icon indicating copy to clipboard operation
percona-toolkit copied to clipboard

Add CPU cache configuration info to pt-summary.

Open akopytov opened this issue 7 years ago • 9 comments

akopytov avatar Oct 24 '16 07:10 akopytov

Is anybody looking at external pull requests for PT? Should I use another channel to submit this contribution? Thanks.

akopytov avatar Nov 22 '16 12:11 akopytov

Could you add a comment saying that the code is your own creation and it can be distributed under the BSD licence?

Please check: https://github.com/percona/percona-toolkit/blob/2.2/CONTRIBUTE.md

percona-csalguero avatar Nov 22 '16 15:11 percona-csalguero

The code is my creation and can be distributed under the BSD license.

akopytov avatar Nov 22 '16 15:11 akopytov

I am getting this:

          Designation               Configuration            Size        Associativity
  ========================= ============================== ======== ======================

What's the idea about this PR? What it should do? Could you provide an example?

percona-csalguero avatar Nov 22 '16 15:11 percona-csalguero

It uses data about the CPU cache provided by the dmidecode utility (https://linux.die.net/man/8/dmidecode). pt-summary already uses dmidecode (if avaliable) to provide information about available memory devices. The patch piggybacks on that functionality to describe CPU cache, e.g. available caches, their sizes and associativity.

akopytov avatar Nov 22 '16 17:11 akopytov

I think I tested it on an Intel Xeon machine and worked fine. As I understand, you got empty output. Can you give me the output of dmidecode -t cache on your machine?

akopytov avatar Nov 22 '16 17:11 akopytov

Is there anything I can do to get this PR merged?

akopytov avatar Nov 28 '16 21:11 akopytov

Sorry for the delay. I need to review the changes and if everything is OK, I am going to merge it. Thanks for your help

percona-csalguero avatar Nov 28 '16 21:11 percona-csalguero

CLA assistant check
All committers have signed the CLA.

it-percona avatar May 15 '20 18:05 it-percona