percona-postgresql-operator
percona-postgresql-operator copied to clipboard
K8SPG-728: Configure s3 to support minio for extensions
CHANGE DESCRIPTION
Problem: Extensions storage was not compatible with MinIO due to incorrect S3 configuration.
Cause: The S3 client did not force path-style addressing, and SSL verification issues were preventing proper connections to the MinIO instance.
Solution: Updated S3 configuration to support MinIO by enabling path-style addressing and allowing optional TLS verification settings..
CHECKLIST
Config/Logging/Testability
- [ ] Are all needed new/changed options added to default YAML files?
- [ ] Are all needed new/changed options added to the Helm Chart?
- [ ] Did we add proper logging messages for operator actions?
- [ ] Did we ensure compatibility with the previous version or cluster upgrade process?
- [ ] Does the change support oldest and newest supported PG version?
- [ ] Does the change support oldest and newest supported Kubernetes version?
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@ali3bdalla thank you for your contribution.
I don't think these changes are enough, because newly added fields won't be used ever.
We need to do the following:
- Add these new fields into https://github.com/ali3bdalla/percona-postgresql-operator/blob/3e6b405eaece1640fd19a9a6233b48d0ff7e65a5/pkg/apis/pgv2.percona.com/v2/perconapgcluster_types.go#L583-L591
- Pass these fields' values to extension installer container in https://github.com/ali3bdalla/percona-postgresql-operator/blob/3e6b405eaece1640fd19a9a6233b48d0ff7e65a5/percona/extensions/k8s.go#L63-L93. We need to add these fields only for >= 2.7.0, so please add them conditionally by checking
cr.CompareVersion("2.7.0") >= 0 - Finally pass the flags to extension-installer binary in https://github.com/ali3bdalla/percona-postgresql-operator/blob/3e6b405eaece1640fd19a9a6233b48d0ff7e65a5/build/postgres-operator/install-extensions.sh#L8-L14
@ali3bdalla did you have the chance to check @egegunes comments? Asking because we are planning of having this work released with the 2.7 version of our operator and we are interested in completing it.
| Test name | Status |
|---|---|
| custom-extensions | failure |
| custom-tls | failure |
| demand-backup | failure |
| finalizers | failure |
| init-deploy | skipped |
| monitoring | skipped |
| one-pod | skipped |
| operator-self-healing | skipped |
| pitr | skipped |
| scaling | skipped |
| scheduled-backup | skipped |
| self-healing | skipped |
| sidecars | skipped |
| start-from-backup | skipped |
| tablespaces | skipped |
| telemetry-transfer | skipped |
| upgrade-consistency | skipped |
| upgrade-minor | skipped |
| users | skipped |
| We run 4 out of 19 |
commit: https://github.com/percona/percona-postgresql-operator/pull/1034/commits/4efafe1e95234c5a7e541579018fca40b973cee0
image: perconalab/percona-postgresql-operator:PR-1034-4efafe1e9
Hi, it will be fixed under https://github.com/percona/percona-postgresql-operator/pull/1214