percona-monitoring-plugins icon indicating copy to clipboard operation
percona-monitoring-plugins copied to clipboard

Published 20 hours ago • verified publisher icon percona

unflushed_log handling in ss_get_mysql_stats.php

Open Luit opened this issue 8 years ago • 0 comments

According to the comment in cacti/scripts/ss_get_mysql_stats.php https://github.com/percona/percona-monitoring-plugins/blob/d429df075097989781d52c474518dfc0a99f7e7b/cacti/scripts/ss_get_mysql_stats.php#L608-L613 apparently unflushed_log:

spikes a lot sometimes and it's impossible for it to be more than the log buffer

but in the code under this comment max(unflushed_log, innodb_log_buffer_size) is taken. This seems wrong, as this'll bottom unflushed_log out at innodb_log_buffer_size, instead of capping it at this value.

(I just happened to stumble upon this while looking at this code for no particular reason)

Luit avatar Nov 16 '16 10:11 Luit