mongodb_exporter
mongodb_exporter copied to clipboard
add user and password to uri if the uri does not contain user password
- [#559] Links to other linked pull requests (optional).
- [X] Tests passed.
- [X] Fix conflicts with target branch.
- [ ] Update jira ticket description if needed.
- [ ] Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.
Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum or Discord.
@ShashankSinha252 passing both CI (FeatureBuild) and metrics test
@ShashankSinha252 are there any more changes that should be made by me?
Hello, @naughtyGitCat! Thank you for your contribution! We would love to send you some gifts. Please, contact us at [email protected] with your mailing address, phone number (for delivery only) and T-shirt size.
I have split two arbiter-related commits to https://github.com/percona/mongodb_exporter/pull/607
and this pr will only contains user pass expose commits
please fix linters
@BupycHuk seems weird, the below check
ok github.com/percona/mongodb_exporter/internal/tu (cached)
? github.com/percona/mongodb_exporter/internal/util
have no relation with my change, and some of the checks seem to randomly pass and failed
and the check function InspectContainer seems related to docker env only other than the main logic code
I meant this one https://github.com/percona/mongodb_exporter/actions/runs/6048290809/job/16413363823?pr=560
Yeah, tests are unstable lately and we are working on it
I meant this one https://github.com/percona/mongodb_exporter/actions/runs/6048290809/job/16413363823?pr=560
failed with:
diff --git a/main_test.go b/main_test.go
is caused by
git diff --exit-code
and this command only means to mark two commits changed or not.
I think it was related to the merging from percona main to forked main
ci and lint check rules look like teetering