mongodb_exporter icon indicating copy to clipboard operation
mongodb_exporter copied to clipboard

add user and password to uri if the uri does not contain user password

Open naughtyGitCat opened this issue 3 years ago • 1 comments
trafficstars

  • [#559] Links to other linked pull requests (optional).

  • [X] Tests passed.
  • [X] Fix conflicts with target branch.
  • [ ] Update jira ticket description if needed.
  • [ ] Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum or Discord.

naughtyGitCat avatar Sep 13 '22 06:09 naughtyGitCat

CLA assistant check
All committers have signed the CLA.

it-percona-cla avatar Sep 13 '22 06:09 it-percona-cla

@ShashankSinha252 passing both CI (FeatureBuild) and metrics test

tshcherban avatar Oct 07 '22 12:10 tshcherban

@ShashankSinha252 are there any more changes that should be made by me?

naughtyGitCat avatar Oct 11 '22 09:10 naughtyGitCat

Hello, @naughtyGitCat! Thank you for your contribution! We would love to send you some gifts. Please, contact us at [email protected] with your mailing address, phone number (for delivery only) and T-shirt size.

Aleksa-del avatar Nov 22 '22 12:11 Aleksa-del

I have split two arbiter-related commits to https://github.com/percona/mongodb_exporter/pull/607

and this pr will only contains user pass expose commits

naughtyGitCat avatar Dec 12 '22 07:12 naughtyGitCat

please fix linters

BupycHuk avatar Sep 01 '23 10:09 BupycHuk

@BupycHuk seems weird, the below check

ok  	github.com/percona/mongodb_exporter/internal/tu	(cached)
?   	github.com/percona/mongodb_exporter/internal/util	

have no relation with my change, and some of the checks seem to randomly pass and failed

and the check function InspectContainer seems related to docker env only other than the main logic code

naughtyGitCat avatar Sep 01 '23 10:09 naughtyGitCat

I meant this one https://github.com/percona/mongodb_exporter/actions/runs/6048290809/job/16413363823?pr=560

BupycHuk avatar Sep 01 '23 10:09 BupycHuk

Yeah, tests are unstable lately and we are working on it

BupycHuk avatar Sep 01 '23 10:09 BupycHuk

I meant this one https://github.com/percona/mongodb_exporter/actions/runs/6048290809/job/16413363823?pr=560

failed with: diff --git a/main_test.go b/main_test.go is caused by git diff --exit-code and this command only means to mark two commits changed or not. I think it was related to the merging from percona main to forked main

naughtyGitCat avatar Sep 01 '23 10:09 naughtyGitCat

ci and lint check rules look like teetering

naughtyGitCat avatar Sep 01 '23 10:09 naughtyGitCat