mongodb_exporter icon indicating copy to clipboard operation
mongodb_exporter copied to clipboard

Fix panics from attempts to use nil client

Open trvrnrth opened this issue 2 years ago • 1 comments

PMM-10691

  • [ ] Links to other linked pull requests (optional).

  • [x] Tests passed.
  • [x] Fix conflicts with target branch.
  • [x] Update jira ticket description if needed.
  • [x] Attach screenshots/console output to confirm new behavior to jira ticket, if applicable.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum or Discord.

trvrnrth avatar Sep 12 '22 10:09 trvrnrth

The Handler function could probably benefit from further re-factoring to move client dependant handling into a separate function or similar, but this PR deliberately keeps the changes minimal.

trvrnrth avatar Sep 12 '22 10:09 trvrnrth

@trvrnrth could you please update branch, we will merge

denisok avatar Oct 06 '22 13:10 denisok