ec2-security-groups-dumper icon indicating copy to clipboard operation
ec2-security-groups-dumper copied to clipboard

Published 20 hours ago • verified publisher icon percolate

Fixes #23

Open rk295 opened this issue 6 years ago • 3 comments

I also found having the VpcId in the output useful, so I took the liberty to add it.

I appreciate this might be a breaking change if somebody is depending on the output of this tool.

rk295 avatar Dec 13 '18 12:12 rk295

I've pushed a minor tweak, the JSON output was incorrect.

I'm a bit confused about that AssertionError, what is the AWS API returning for VpcId for you? I've tried it against a bunch of AWS accounts I have and all seem fine.

The only thing I can think of is maybe you have some Security Groups for the pre VPC era and the VpcId field is being returned as null or something?

rk295 avatar Dec 13 '18 22:12 rk295

Yes, I have some old classic stuff around, and in this case, the vpc_id is a NoneType.

lra avatar Dec 14 '18 01:12 lra

I'm not sure how you'd prefer this fixed, I've pushed a commit which works around the lack of the VpcId field by defaulting it to an empty string. See line 316.

rk295 avatar Dec 14 '18 10:12 rk295