Federico Perini comments

Results 172 comments of


                                            Federico Perini

Fix: `--target` option should only run the desired target

Thanks Brad. Let's wait a few days and, if there are no further comments, I will merge this PR.

linalg: QR factorization

From Fortran Monthly call: - [x] require that `Q` and `R` have exact sizes for either the full or the reduced problem (do not just check that there is "enough"...

linalg: QR factorization

Thank you for your edits @jvdp1 @jalvesz, looks much better now.

linalg: QR factorization

Thank you @jvdp1. I think it makes sense to wait for a bit longer, and then merge if there are no further comments.

linalg: QR factorization

Thank you @jvdp1 @jalvesz, I will merge due to no outstanding comments.

Addition of `sort_adj` to sort an rank 1 array in the same order as an input array

Thank you for this PR @jvdp1. I agree with @jalvesz and like the `adjoint_array` name. Regarding your questions: - I believe the original `sort_index` is appropriate because it represents an...

Addition of `sort_adj` to sort an rank 1 array in the same order as an input array

@jvdp1 besides some conflicts, this PR seems ready to merge. I don't have permission to resolve them on your branch.

Surface derivative

Thank you! Much appreciated. I'm trying to understand how `pardtc` works (never used it myself). If we look at the corresponding functionality in SciPy, it looks like it should be...

fpm tests failing to run/compile

Thank you for reporting this @banana-bred - looks related to this issue with `test-drive`: https://github.com/fortran-lang/test-drive/issues/49 Yes, we don't build fpm with `gfortran-15` yet but this issue needs to be addressed...

fpm tests failing to run/compile

Closed by #1150