Per Tillisch

>not in analogRead. This issue was fixed by https://github.com/arduino/reference-en/pull/463 >the analog input pin constants are not mentioned in the Arduino reference - not under Constants This issue remains.

Hi @brewmanz. Thanks for taking the time to submit an issue. The `tone()` function is not ignoring the `duration` parameter, it's just not using it as you expect. This function...

The problem is the miscapitalization of the filename. It should be **A**rduino.h, not **a**rduino.h

>Do these platforms have official identifiers (something that can be used in code, like promini or pro_mini for the "Pro Mini")? There is a standard convention that a macro be...

>"undocumented API" #### `util/crc16.h` it's definitely documented: https://www.nongnu.org/avr-libc/user-manual/group__util__crc.html #### `rom/crc.h` I'm not sure. I see there is doxygen documentation in the source code: https://github.com/espressif/esp-idf/blob/v3.3.4/components/esp32/include/rom/crc.h but I didn't find that documentation...

This is definitely a problem. It's difficult to say whether some of these things are undocumented because nobody ever got around to documenting them (or even creating a place to...

Follow the same precedent Arduino uses by prefixing global macro names with the organization name. This creates a "namespace" of sorts for your macros to avoid collisions: `IANFIXES_ARDUINO_CI`

Note that since Teensyduino is a modified version of the Arduino IDE as Strooom mentioned, rather than a standard boards platform as we are used to using for adding support...

@ianfixes have you taken a look at the ArduinoCore-API unit tests? https://github.com/arduino/ArduinoCore-API/tree/master/test/src ArduinoCore-API is all the hardware agnostic code of the core library so it shouldn't really require much mocking....

The truth is that, even though I have some experience with unit tests and mocking in other contexts, I really don't understand much of what is happening in this project....