Giuseppe De Marco

This PR Closes https://github.com/openid/oid4vc-haip-sd-jwt-vc/issues/69 - aligns the use of the defined terms Issuer, Holder and Verifiers within the text - adds the section hash algorithms - adds Wallet Instance Attestation...

editorial: Wallet is a defined term

1

This PR aligns the term Wallet as a defined term within the document

I-D.terbu-sd-jwt-vc doesn't support OIDC Federation

7

I-D.terbu-sd-jwt-vc doesn't support OIDC Federation, that's a webpki with trust chains and a solid alternative to X.509 _Originally posted by @peppelinux in https://github.com/vcstuff/oid4vc-haip-sd-jwt-vc/pull/56#discussion_r1269938935_ Torsten's reply: nothing in the sd-jwt vc...

OpenID Federation 1.0 for HAIP

8

[OpenID Federation 1.0](https://openid.net/specs/openid-federation-1_0.html) provides: - a consolidated approach to build an infrastructure of trust; - a secure way to establish trust among different parties; - automatic mechanisms to evaluates the...

presentation_definition may be provided in the RP's metadata

2

I think that should enable the possibility to obtain the presentation_definition from the metadata instead that requiring it only in the authorization request having the presentation_definition in the metadata allows:...

Wallet Instance error codes

1

once this PR goes in (https://github.com/openid/OpenID4VCI/pull/64/files), we should probably add `insufficient_wallet_security` or something as an error code? for now, let's open an issue on this. _Originally posted by @Sakurann in...

client_id_scheme doesn't support Federation

1

In https://vcstuff.github.io/oid4vc-haip-sd-jwt-vc/draft-oid4vc-haip-sd-jwt-vc.html#section-5-1.5 I read ```` client_id_scheme value MUST be either x509_san_dns or verifier_attestation. Wallet MUST support both. Verifier MUST support at least one. (pending OID4VCI PR #524 for verifier_attestation) ````...

we should mandate the SVG file format for the logo, since it grants a high quality rendering in any kind of display resolution

2

we should mandate the SVG file format for the logo, since it grants a high quality rendering in any kind of display resolution _Originally posted by @peppelinux in https://github.com/vcstuff/oid4vc-haip-sd-jwt-vc/pull/56#discussion_r1263741725_

I read here https://github.com/vcstuff/high-assurance-profile/blob/main/draft-high-assurance-profile-oid4vc-sd-jwt-vc.md#issuer-identification-and-key-resolution-to-validate-an-issued-credential-issuer-key-resolution that only x509 and .well-known/jwt-issuer MUST be supported At the same time I have the "perception" that Federation has a higher level for the attestation of...

chore: c_nonce is recommended and AS takes care

1

This PR aims to resolve the issue https://github.com/openid/OpenID4VCI/issues/313 where @andprian expressed her sensibility about some details that amtters about the security and the behaviour that an implementer may expect from...