pep8speaks icon indicating copy to clipboard operation
pep8speaks copied to clipboard

Handle payloads with large number of files changed

Open OrkoHunter opened this issue 4 years ago • 3 comments

Related issue: https://github.com/OrkoHunter/pep8speaks/issues/178

In PR where 100s of files are changed, there is a possibility the request will timeout. Since, the bot makes a comment, the GitHub Payload can be responded immediately. The lint job and commenting on PR can be done asynchronously.

OrkoHunter avatar Jun 29 '20 11:06 OrkoHunter

Should this be tackled with a full fledged task queue? Or by just using an async function? I can come up with a PR if you want.

grapheo12 avatar Jun 29 '20 18:06 grapheo12

Hey Shubham! Thank you for the interest! Even if task queue seems like a good way to go, it might be overkill here. An async function should be sufficient for most of the cases. I can not think of a drawback.

OrkoHunter avatar Jun 30 '20 02:06 OrkoHunter

@tushar5526 We might work on making pep8speaks async, I can be a major rework, Also thinking of using fastapi as an ASGI.

Mr-Sunglasses avatar Apr 30 '24 05:04 Mr-Sunglasses