django-mail-factory icon indicating copy to clipboard operation
django-mail-factory copied to clipboard

Check for mandatory context before calling get_context_data

Open bhrutledge opened this issue 9 years ago • 2 comments

In BaseMail.__init__, I think it would be helpful to validate context against self.get_params (and raise MissingMailContextParamException) before doing anything else. That way, self.get_context_data could safely reference the required params while adding additional context.

But, maybe there's some element of the flow that I'm missing...

bhrutledge avatar Aug 18 '16 14:08 bhrutledge

@bhrutledge You are probably correct, do you mind working on a PR to fix that? I will be happy to review it and help.

Natim avatar Aug 18 '16 14:08 Natim

Will do!

bhrutledge avatar Aug 19 '16 01:08 bhrutledge