opentibia_sprite_pack icon indicating copy to clipboard operation
opentibia_sprite_pack copied to clipboard
verified publisher icon peonso

TFS bug

Open peonso opened this issue 8 years ago • 4 comments

Actual bug with TFS, nothing can be done at our side. This is hardcoded, should be commented out/removed:

https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L70-L81

peonso avatar Dec 01 '17 15:12 peonso

Did you post an issue about it on the TFS repo? Hardcoded itemids in C++ is bad. It should at least be from a configurable lua or xml file.

What about: https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L1237

https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L1315

https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L1379

Znote avatar Dec 15 '17 15:12 Znote

@Znote I didn't noticed it because the pack didn't have those high ids. I also didn't posted it there because I didn't have a suggestion to address it.

peonso avatar Dec 15 '17 15:12 peonso

https://github.com/otland/forgottenserver/blob/18fbfdc33a65c5cba9d5a02bcc8116dfd10362b0/src/protocolgame.cpp#L2631

https://github.com/otland/forgottenserver/blob/18fbfdc33a65c5cba9d5a02bcc8116dfd10362b0/src/protocolgame.cpp#L1444

peonso avatar Dec 24 '17 05:12 peonso