Alasdair McLeay

Document deprecation strategy/process

2

In CONTRIBUTING.md we should document how we handle breaking changes to components, including renaming or deprecating components. e.g. when DateInput was renamed to DateField in #420 Options: - remove deprecated...

Instead of using FONT_SIZE and LINE_HEIGHT directly in CSS, go via the font `@govuk-react/lib` `typography.font()` util. Review difference in SIZE_24 line height original todos: > FONT_SIZE and LINE_HEIGHT can be...

Remove use of defaultProps on functional components

7

Further to #949 defaultProps should be replaced with default values on functional components related https://github.com/facebook/react/pull/16210 https://github.com/yannickcr/eslint-plugin-react/issues/2396

Use `asChild` prop instead of `as` prop

2

The `as` prop is hard to type. We can use https://github.com/kripod/react-polymorphic-types but still don't get `forwardedAs` or typed events. i.e. ```jsx console.log(event.target.href)} /> ``` would still throw an error. Using...

React.Children.map rethink (Context API?)

1

We use `React.Children.map` on these components: - Breadcrumbs - DocumentFooterMetadata - Footer.MetaLinks - Footer.NavigationLinks - ListNavigation We may want to swap this out, e.g. for the context API. This ticket...

Add support for `govuk-main-wrapper--l`, which uses govuk-responsive-padding(8, "top");

Now we have a Footer component, it should be the defaultProp for Page.footer Removed TODO: > // , // TODO: add Footer component once built

I've not updated the Tabs stories to enable 'show code' as they are all fairly complex class based components. The stories should show fairly unopinionated usage of the components -...

> I think tests like this are giving false code coverage metrics and should be removed or updated to assert key features of a default render _Originally posted by @penx...

e.g. ```jsx ``` should render a Radix Loader primitive styled to fit the GOV.UK design system.