Alasdair McLeay
Alasdair McLeay
e.g. for storybook links https://www.typescriptlang.org/play/4-1/new-js-features/see-in-jsdoc.ts.html
I don't personally use it and don't want to maintain it if it's not being used. Could be replaced with https://github.com/CVarisco/create-component-app or similar
If Chromatic doesn't run, CI should still fail if some key stories aren't loading. Could perhaps test with Cypress, or maybe Storyshots would tell us. > yeah I think we...
- build a page with govuk-react on codesandbox with a Page, H1, H2, DateField, Button (and more if you want) - build the same page with govuk-frontend on another codesandbox...
See https://github.com/penx/govuk-react-example/issues/16 The example site should have a good and measured coverage of govuk-react. When a new version of govuk-react is published, the example site should update (ideally via Greenkeeper)....
- include code coverage from chromatic in metric - delete snapshots without losing code coverage by ensuring all fixtures are in storybook
1020px min-width media query should come from constants `@media only screen and (min-width:1020px)`
Originally from a TODO adding in #276 and #333 - Add test for supporting text (added [here](https://github.com/govuk-react/govuk-react/pull/276/files#diff-5219f0eb4b4d6ef5ebb81909417e2b5f55aed1aac474dcbe9dd72ff2a155be72R49), not sure what was meant here, @Loque- ?) - Review code snippet styling...
Start button with icon is full width on desktop, but shouldn't be Should match https://design-system.service.gov.uk/patterns/start-pages/